Skip to content

Add suggested flag to instances-metadata#587

Open
dessalines wants to merge 2 commits intomainfrom
suggested_flag
Open

Add suggested flag to instances-metadata#587
dessalines wants to merge 2 commits intomainfrom
suggested_flag

Conversation

@dessalines
Copy link
Member

No description provided.

@Nutomic
Copy link
Member

Nutomic commented Feb 10, 2026

Im currently making some changes in #586. Seems to me that having the suggested instances for each country in a single place is better.

https://github.com/LemmyNet/joinlemmy-site/pull/586/changes#diff-f78556500c68f47e12256acdcb2e85d0aa6847ba207adfd7344e2be7cce56af1R9

@dessalines
Copy link
Member Author

This could work with that, you would just serialize the instances.filter(i => i.suggested) for the suggested endpoint.

@Nutomic
Copy link
Member

Nutomic commented Feb 12, 2026

Yes it would work, but then it becomes very difficult to see which instances are actually suggested. With changes in the other PR the logic is much more complex, and so its good to have it all in one place.

@dessalines
Copy link
Member Author

I'm thinking now that the endpoint should probably just serialize the entire instances_metadata list. That'd be much more useful for apps to build their own in-app pickers. Or just use a simple dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants