✨ (signer-aleo) [LIVE-23853]: Add get address command support with tests#1329
Merged
mbertin-ledger merged 4 commits intodevelopfrom Feb 27, 2026
Merged
Conversation
…default input value in the sample app
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
0xMM-L
changed the title
9 tasks
9 tasks
Base automatically changed from
feat/live-23538-add-aleo-signer-with-get-config-command
to
develop
February 27, 2026 12:54
mbertin-ledger
requested changes
Feb 27, 2026
| const buffer = parser.extractFieldByLength(addressLength); | ||
| if (buffer === undefined) { | ||
| return CommandResultFactory({ | ||
| error: new InvalidStatusWordError("Unable to extract address"), |
Member
There was a problem hiding this comment.
[MUST] StatusWordError should be used for status word being different than 9000
You have to create a dedicated error, which could be AleoGetAddressParsingError
mbertin-ledger
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR introduces new command to the aleo signer package.
Now it will be possible to send Get Address commands to the devices.
(This PR is the continuation of the work done in this PR and is based on changes made there)
❓ Context
JIRA or GitHub link: LIVE-23538
Feature: Aleo Signer package
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers