Skip to content

✨ (signer-aleo) [LIVE-23538]: Add initial aleo signer files and handler for get app config#1297

Open
0xMMBD wants to merge 6 commits intoLedgerHQ:developfrom
blockydevs:feat/live-23538-add-aleo-signer-with-get-config-command
Open

✨ (signer-aleo) [LIVE-23538]: Add initial aleo signer files and handler for get app config#1297
0xMMBD wants to merge 6 commits intoLedgerHQ:developfrom
blockydevs:feat/live-23538-add-aleo-signer-with-get-config-command

Conversation

@0xMMBD
Copy link

@0xMMBD 0xMMBD commented Feb 11, 2026

📝 Description

This PR introduces the initial setup of the new Aleo signer package (@ledgerhq/device-signer-kit-aleo).
To limit the scope of changes, currently only the get app config command is implemented including tests and error definitions.

(Remaining commands will be introduced in the next PRs)

❓ Context

  • JIRA or GitHub link: LIVE-23538
  • Feature: Aleo signer library

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Documentation is up-to-date
  • Impact of the changes:
    • New package @ledgerhq/device-signer-kit-aleo
    • Sample add updated and now includes the Aleo signer UI elements
    • No breaking changes to any existing packages

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@0xMMBD 0xMMBD requested a review from a team as a code owner February 11, 2026 11:50
@vercel
Copy link

vercel bot commented Feb 11, 2026

@0xMMBD is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@mbertin-ledger mbertin-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MUST] Do Unit tests

@0xMMBD
Copy link
Author

0xMMBD commented Feb 12, 2026

hello @mbertin-ledger This PR contains only setup of the aleo-signer package and implementation of one command - get app config. Rest of the commands and their tests will be included in the upcoming PRs.
Currently this PR contains two test files:

  • packages/signer/signer-aleo/src/internal/app-binder/command/GetAppConfigCommand.test.ts
  • packages/signer/signer-aleo/src/internal/app-binder/command/utils/aleoApplicationErrors.test.ts

Is there anything else that you think must be tested at this stage? @mbertin-ledger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants