✨ (signer-aleo) [LIVE-23538]: Add initial aleo signer files and handler for get app config#1297
Open
0xMMBD wants to merge 6 commits intoLedgerHQ:developfrom
Conversation
|
@0xMMBD is attempting to deploy a commit to the LedgerHQ Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
hello @mbertin-ledger This PR contains only setup of the aleo-signer package and implementation of one command - get app config. Rest of the commands and their tests will be included in the upcoming PRs.
Is there anything else that you think must be tested at this stage? @mbertin-ledger |
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR introduces the initial setup of the new Aleo signer package (
@ledgerhq/device-signer-kit-aleo).To limit the scope of changes, currently only the get app config command is implemented including tests and error definitions.
(Remaining commands will be introduced in the next PRs)
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
@ledgerhq/device-signer-kit-aleo🧐 Checklist for the PR Reviewers