fix(security): resolve new high npm audit findings (brace-expansion, shell-quote)#3679
fix(security): resolve new high npm audit findings (brace-expansion, shell-quote)#3679marcelfolaron wants to merge 1 commit into
Conversation
…shell-quote) Two high advisories published upstream since #3667 re-red the npm audit --audit-level=high gate repo-wide: - brace-expansion (GHSA-3jxr-9vmj-r5cp) — DoS via exponential-time expansion; transitive under glob/@sentry tooling - shell-quote (GHSA-395f-4hp3-45gv) — quadratic-complexity DoS in parse() Lockfile-only in-range refresh via npm audit fix (15 lines); no package.json changes. Gate exits 0; npx mix compiles cleanly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Status: ready-pending-CI · Priority: P2 (build-chain security, no runtime exposure) · Next action: run the audit/lint gate on this head, then merge · Owner: @marcelfolaron / @broskees Automated maintainer review (advisory only — not an approval; merge authority stays with @marcelfolaron / @broskees). Reviewed at head 1. Intent: Clears two newly-published high advisories re-redding the 2. Change requests — none blocking. Confirm-before-merge only:
3. Acceptance checklist (must pass before merge):
4. CI status — ⚠: Combined status on Advisory only — not an approval, not marking ready, not merging. Merge authority stays with @marcelfolaron / @broskees. |
Why
Two high advisories were published upstream after #3667 merged, so the
npm audit --audit-level=highgate is red repo-wide again:brace-expansion— GHSA-3jxr-9vmj-r5cp, DoS via exponential-time expansion (transitive under glob / @sentry tooling)shell-quote— GHSA-395f-4hp3-45gv, quadratic-complexity DoS inparse()Both are build-chain dev dependencies; no runtime exposure.
What
Lockfile-only in-range refresh via
npm audit fix(15 changed lines). Nopackage.jsonchanges.Verification
npm audit --audit-level=highexits 0npx mixcompiles cleanlyNote: the audit gate is time-sensitive — new advisories re-red it without any code change (this is the second such PR in three days). If it keeps recurring, worth considering a scheduled weekly
npm audit fixPR bot or pinning the gate job to fail only on new findings vs a checked-in allowlist.🤖 Generated with Claude Code