Test reading old int128 bitpacked page#637
Open
mdbenito wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #633 (comment), this PR adds a test where we simulate an "old" persisted page by forging the metadata. We need only test working integer ranges because the case with min = INT128_MIN could never have written any pages to disk due to the bug that was fixed. For this reason I thought that the alternative, a binary fixture (of which I found just one for the WAL), wouldn't have really provided more information.
The test does not call
compressNextPage(which would use the new path). Instead, it copies the three steps in the old code: metadata, delta computation, packing, then feeds the resulting bytes into the decompressor and asserts roundtrip.