Move ~/.lmmsrc.xml to canonical config location#8264
Open
sqrvrt wants to merge 1 commit intoLMMS:masterfrom
Open
Move ~/.lmmsrc.xml to canonical config location#8264sqrvrt wants to merge 1 commit intoLMMS:masterfrom
sqrvrt wants to merge 1 commit intoLMMS:masterfrom
Conversation
Member
|
I would copy and not move because in my case (and I think at least some other users do this too) I'm running multiple versions of LMMS. I think this could be more likely in the future if there are changes that break backward compatibility. I know a lot of other users who switch from nightly back to alpha, etc, or try out nightly and go back to stable. |
Contributor
Author
|
My main argument for moving was just somewhat of a clarification that file being observed has moved, but i see the problem. Would probably be good to get the point across in some way though without reading the patch notes, maybe a popup after file copying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
$HOME/.lmmsrc.xmlto$XDG_CONFIG_HOME/lmms/lmmsrc.xml(and similar dirs in other platforms) to conform to modern standards.Currently in this PR, if file doesn't exist in new location, old one gets copied, and if directory doesn't exist it gets created on startup instead of on write like the file does. Should i move it? Creation also silently fails if directory is somehow unable to be created, though i'm not crazy enough to test if writing a file would still emit a warning.
Worthy of note, since it's now a proper config file, the leading dot is removed. Instead of copying old file could be moved. Current behavior is for testing convenience.