Fix PianoRoll toolbar buttons not being disabled initially#8173
Fix PianoRoll toolbar buttons not being disabled initially#8173allejok96 wants to merge 7 commits into
Conversation
|
I noticed while testing that the piano roll window title doesn't update sometimes.
However, it appears that manually adding the clip and double-clicking to open it in the piano roll doesn't cause this issue. |
|
Good find @regulus79 ! There was a difference in what signals got connected when calling I've added a separate |
regulus79
left a comment
There was a problem hiding this comment.
The changes look fine to me.
The way the window title defaults to the track name if the clip has no name is nice!
Co-authored-by: Fawn <[email protected]>
When piano roll is opened for the first time in a project that has clips, it shows the help icon, but the toolbar is not grayed-out. If a clip is opened and then deleted, the toolbar gets grayed-out. This fixes it so the toolbar is disabled by default (by running
setCurrentMidiClip(nullptr)after the connections are made)Also:
m_fileToolsButtonas a class member, since all tool buttons get enabled/disabledPianoRollWindow::setCurrentMidiClip