Open
Conversation
Member
|
Thanks for doing this @jenpaulhus ! I think we need more eyes on this than mine. Initial thoughts are positive, but also:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a landing page for elliptic curves (similar to the landing page for modular forms) and finishes fixing issue #2479
http://localhost:37777/EllipticCurves/
It could use some feedback before it is merged.
For EC/Q things work pretty smoothly. The "Elliptic curves" bread goes to the page above (click on "Elliptic curves" in the bread on any EC page).
For ECNF, this does change the behavior of the bread a bit. It adds a Q(\alpha) bread at the top of the main page and the RCS (RSC? CRS?) knowls:
http://localhost:37777/EllipticCurve/
But then for individual pages, it does not currently add a Q(\alpha) bread as there is already a Q(blah) bread added for that particular \alpha. I could add Q(\alpha) also, but I wasn't sure if that made the bread too long.
I can easily change this behavior, just wanted to get feedback before doing so.
Also, I have commented out some lines of code that I will remove once this is ready to be merged, but I wanted to keep them in to easily undo parts as needed (adding this note as much to remind myself later as for anyone else).