Skip to content

Code snippets from snippet-generate action#6934

Open
github-actions[bot] wants to merge 1 commit intomainfrom
create-pull-request/patch
Open

Code snippets from snippet-generate action#6934
github-actions[bot] wants to merge 1 commit intomainfrom
create-pull-request/patch

Conversation

@github-actions
Copy link
Copy Markdown

This is an auto-generated PR with code snippets from yaml files.

@roed314
Copy link
Copy Markdown
Member

roed314 commented Mar 14, 2026

@rvisser7 it looks like there were some %s that didn't get substituted?

@rvisser7
Copy link
Copy Markdown
Contributor

Thanks - I've submitted the PR #6935 which should fix the silly labelling issue with the snippet tests for the ECQ isogeny class 37.a. 🙂

The %s errors seem to be coming from the CI attempting to generate Pari and Oscar snippet log files for the ECNF isogeny classes 11.1-a and 81.1-CMa. But I don't think Pari or Oscar currently supports isogeny classes for elliptic curves over number fields.

So I guess I'm a bit confused why the CI is generating these log files - I've only specified Sage as a valid language in the snippet tests for 11.1-a and 81.1-CMa. In practice this shouldn't affect users, since the ECNF isogeny class code snippets are only implemented in Sage, and the other languages (Pari/Oscar/Magma) don't appear in the UI or the sidebar download links.

I'm probably just misunderstanding how the snippet tests work. This is how I'm currently implementing the tests in lmfdb/ecnf/code.yaml:

snippet_test:
  test11.1-a: 
    label: 11.1-a
    langs:
      - sage
    url: EllipticCurve/2.0.11.1/11.1/a/download/{lang}
  test11.1-a1: 
    label: 11.1-a1
    url: EllipticCurve/2.0.11.1/11.1/a/1/download/{lang}
  test81.1-CMa: 
    label: 81.1-CMa
    langs:
      - sage
    url: EllipticCurve/2.0.3.1/81.1/CMa/download/{lang}
  test81.1-CMa1: 
    label: 81.1-CMa1
    url: EllipticCurve/2.0.3.1/81.1/CMa/1/download/{lang}

I guess I'm probably doing something wrong here, but I'm not sure what the fix is? Maybe I need to set langs somewhere else (or maybe there's a bug in the CI for generating the snippet logs)?

havarddj added a commit to havarddj/lmfdb that referenced this pull request Mar 16, 2026
This commit adds documentation of the snippet testing system in
`Development.md`, as well as fixes a bug with the lang tag in
snippet_test tags being ignored.

It also implements the same elliptic curve code.yaml fix as LMFDB#6935.
AndrewVSutherland added a commit that referenced this pull request Mar 20, 2026
Add documentation of snippet testing; fix lang tag issue in #6934
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 41f1677 to 6929fe3 Compare March 20, 2026 14:49
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 6929fe3 to d5bf881 Compare March 22, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants