Adding auto generated toString method for structs#2169
Open
gtebrean wants to merge 14 commits intoLFDT-web3j:mainfrom
Open
Adding auto generated toString method for structs#2169gtebrean wants to merge 14 commits intoLFDT-web3j:mainfrom
gtebrean wants to merge 14 commits intoLFDT-web3j:mainfrom
Conversation
Signed-off-by: Angelina <[email protected]>
|
What does this PR do?
|
gtebrean
commented
Mar 20, 2025
codegen/src/test/java/org/web3j/codegen/GenerateToStringMethodTest.java
Outdated
Show resolved
Hide resolved
Julius278
reviewed
Mar 25, 2025
| final TypeSpec.Builder builder = | ||
| TypeSpec.classBuilder(structName) | ||
| .addModifiers(Modifier.PUBLIC, Modifier.STATIC); | ||
| builder.addMethod(generateToStringMethod(namedType.getComponents())); // ADDED THIS LINE |
Contributor
There was a problem hiding this comment.
Hey @aceppaluni,
I guess you wont need a comment here
There was a problem hiding this comment.
Hi @Julius278 That was my mistake. They were left behind from when I was testing. Ill be sure to remove then, thank you!
Julius278
reviewed
Mar 25, 2025
|
|
||
| builder.superclass(namedType.isDynamic() ? DynamicStruct.class : StaticStruct.class); | ||
| builder.addMethod(constructorBuilder.build()); | ||
| builder.addMethod(generateToStringMethod(namedType.getComponents())); // Added this line |
Contributor
There was a problem hiding this comment.
same here, no comment needed
Signed-off-by: Angelina <[email protected]>
Signed-off-by: Angelina <[email protected]>
|
Hi @gtebrean Am I to undo the work I have done on this PR? |
Signed-off-by: Angelina <[email protected]>
|
@gtebrean I noticed the branch is behind. Should I try to sync the branch to test the build? |
… adapt to newly added toString() method in generated wrapper Signed-off-by: AlstonCao <[email protected]>
|
@gtebrean @FangshuoCao Can we merge this and close the issue? |
Contributor
Author
|
@aceppaluni please give me rights to push changes to this repos, I made a series of updates in order to can merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
required
Where should the reviewer start?
required
Why is it needed?
required
Checklist