ADD: EIGEN: check using /openmp#36
Closed
danil-kalina wants to merge 2 commits intoKvanTTT:masterfrom
Closed
Conversation
KvanTTT
requested changes
Jan 18, 2026
Comment on lines
+197
to
+204
| #ifdef USE_EIGEN_BACKEND | ||
| if(Eigen::nbThreads() <= 1) { | ||
| cout << "Too Few Eigen Threads: " << Eigen::nbThreads() << endl; | ||
| cout << "Open «Project Properties»" << endl; | ||
| cout << "Go To «Configuration Properties» → «C/C++» → «Language»" << endl; | ||
| cout << "Set «Open MP Support» = «Yes(/openmp)»" << endl; | ||
| } | ||
| #endif // USE_EIGEN_BACKEND |
Owner
There was a problem hiding this comment.
I suppose the intrusction is relevant only for Windows when using Visual Studio (I don't have projects when I use CLion). The check should be extended to cover it.
Also, I suppose a single thread is a valid option (it can be used for testing).
Consider the following fix:
#ifdef USE_EIGEN_BACKEND
if(Eigen::nbThreads() == 0) {
cout << "There is no Eigen threads." << endl;
#ifdef MSVC
cout << "If you use Visual Studio try the following:" << endl;
cout << "Open «Project Properties»" << endl;
cout << "Go To «Configuration Properties» → «C/C++» → «Language»" << endl;
cout << "Set «Open MP Support» = «Yes(/openmp)»" << endl;
#else
cout << "Enable Open MP support or increase the number of Eigen threads" << endl;
#endif
}
#endif
Owner
|
fixed by #41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.