block: tolerate non-dict first_letter_style/first_line_style#2765
Closed
SAY-5 wants to merge 1 commit into
Closed
Conversation
Closes Kozea#2717. `|=` raises if a caller passes False/True; treat anything non-dict as 'no inherited style'.
Member
|
Hi, Thanks for your pull request! This is more an issue about what is provided to the function, so we should rather avoid to have a dict here. The issue was already addressed by #2740. So I’ll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2717.
|=raisesTypeErrorif a caller passes a bool; treat anything non-dict as no inherited style.