Quality: Non-exhaustive-at-runtime enum mapping can throw NoWhenBranchMatchedException#174
Open
Nam0101 wants to merge 1 commit intoKotlin:mainfrom
Conversation
…nchmatchedexception` `KaSeverity.toLsp()` uses an exhaustive `when` over current enum constants only. If this library is run with a newer Kotlin Analysis API that adds a new `KaSeverity`, Kotlin can throw `NoWhenBranchMatchedException` at runtime during diagnostics conversion, crashing/interrupting diagnostic publishing. Affected files: kotlinCompilerDiagnosticUtils.kt Signed-off-by: Nguyen Van Nam <nam.nv205106@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! 👋
While going through the codebase, I noticed a minor opportunity for improvement regarding
features-impl/kotlin/src/com/jetbrains/ls/api/features/impl/kotlin/diagnostics/compiler/kotlinCompilerDiagnosticUtils.kt.Context:
KaSeverity.toLsp()uses an exhaustivewhenover current enum constants only. If this library is run with a newer Kotlin Analysis API that adds a newKaSeverity, Kotlin can throwNoWhenBranchMatchedExceptionat runtime during diagnostics conversion, crashing/interrupting diagnostic publishing.Proposed fix:
Add a defensive
elsebranch to keep behavior stable across dependency version drift, e.g.:internal fun KaSeverity.toLsp(): DiagnosticSeverity = when (this) {
KaSeverity.ERROR -> DiagnosticSeverity.Error
KaSeverity.WARNING -> DiagnosticSeverity.Warning
KaSeverity.INFO -> DiagnosticSeverity.Information
else -> DiagnosticSeverity.Information
}
Files touched:
features-impl/kotlin/src/com/jetbrains/ls/api/features/impl/kotlin/diagnostics/compiler/kotlinCompilerDiagnosticUtils.kt(modified)(Note: Tested the changes locally to ensure everything works as expected. Let me know if you need any adjustments, happy to help!)
—
NamNV
📍 Hanoi, Vietnam
📧 nam.nv205106@gmail.com