Skip to content

Removed redundant move overloads where insideGroup argument doesn't affect the result#1793

Merged
koperagen merged 1 commit intomasterfrom
redundant-move-overloads
Apr 8, 2026
Merged

Removed redundant move overloads where insideGroup argument doesn't affect the result#1793
koperagen merged 1 commit intomasterfrom
redundant-move-overloads

Conversation

@koperagen
Copy link
Copy Markdown
Collaborator

vararg columns: String can only be top-level columns, so insideGroup true/false argument effectively always give the same result as overload of the function without it:

public fun <T> DataFrame<T>.moveToStart(vararg columns: String)
public fun <T> DataFrame<T>.moveToEnd(vararg columns: String)
public fun <T> DataFrame<T>.moveTo(newColumnIndex: Int, vararg columns: String)

follow up on #1255

vararg columns: String can only be top-level columns, so insideGroup true/false argument effectively always give the same result as overload of the function without it
@koperagen koperagen added this to the 1.0.0-Beta5 milestone Apr 8, 2026
@koperagen koperagen self-assigned this Apr 8, 2026
@Jolanrensen
Copy link
Copy Markdown
Collaborator

No clue how I missed this checking #1489 XD thanks!

@koperagen koperagen merged commit 208d457 into master Apr 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants