docs(hardwareselector.getpixelinformation): use vtkDebugMacro instead…#3399
Open
GMrrc wants to merge 1 commit intoKitware:masterfrom
Open
docs(hardwareselector.getpixelinformation): use vtkDebugMacro instead…#3399GMrrc wants to merge 1 commit intoKitware:masterfrom
GMrrc wants to merge 1 commit intoKitware:masterfrom
Conversation
Member
… of console.log fix Kitware#3398
5c141f6 to
90949b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… of console.log
fix #3398
Context
Currently, getPixelInformation always logs debug information to the console.
This can be noisy in production and makes debugging other parts harder.
This PR replaces console.log statements with vtkDebugMacro.
Related feature request: fix #3398
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting