fix(RWInteractor): async requestPointerLock - #3205
Merged
Merged
Conversation
|
I just verified this change in https://github.com/SironaMedical/services-frontend/pull/6140 - looks good to me! Could we get this merged? |
floryst
marked this pull request as ready for review
March 14, 2025 17:33
floryst
force-pushed
the
requestpointerlock-async
branch
from
March 14, 2025 17:34
7240b49 to
73ab82f
Compare
floryst
enabled auto-merge
May 30, 2025 19:56
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
May 30, 2025
Collaborator
|
@floryst Could you please rebase this change? It seems its ready for merging otherwise. |
|
Bump - can we get this PR into a mergeable state? |
jadh4v
force-pushed
the
requestpointerlock-async
branch
from
May 8, 2026 18:01
f5ab529 to
d0148bf
Compare
|
🎉 This PR is included in version 35.14.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Chrome 131+ now requests permissions for pointer lock. We need to ensure that pointer lock is achieved before continuing with interactions.
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting