You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The autoResize property has been added to address an issue when using an XR device. Setting it to false should prevent trame from resizing the render window on the server side based on the client component size. When autoResize is set to true, the server will match the size of the client's render window and won't fit perfectly on a VR/AR headset display.
Commit dd87cdf is unrelated but it fixed a bug I encountered when making these changes.
We can either wait, or you could test the vtk version in start_xr (py) at runtime to make sure the xr capability is available. If not you can warn to use a newer version of vtk.
@munozco i saw that you merged the upstream VTK MR this week. Let's move forward with this. After the weekly release artifacts become available, you can check against that version 9.6.20260328 like Seb said.
I'm afraid WebXR support in trame will be limited (unless using the WebXR emulator). When synchronizing the vtk state (when the slider is changed in the webxr example) while a WebXR session is active, the render window is resized to 10x10 (I think?). I tried to change a few things in vtk-wasm, but I wasn't able to find a solution...
@jourdain@jspanchu Are you okay with merging this ? I'll open an issue about this bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add support for WebXR.
This PR depends on the following VTK merge request: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/12221
The
autoResizeproperty has been added to address an issue when using an XR device. Setting it to false should prevent trame from resizing the render window on the server side based on the client component size. WhenautoResizeis set to true, the server will match the size of the client's render window and won't fit perfectly on a VR/AR headset display.Commit dd87cdf is unrelated but it fixed a bug I encountered when making these changes.
Cc: @LucasGandel @finetjul