Skip to content

Issue 1547 large image conversion #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryonLewis merged 7 commits into from
Dec 2, 2025
Merged

Issue 1547 large image conversion #1548

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bf63663
add more speed divisions to playback rate, update volume to have disp…
BryonLewis Nov 18, 2025
39f92ec
only convert when there is media to convert
BryonLewis Nov 18, 2025
9b3b067
if image will not decode, convert to large image
BryonLewis Nov 18, 2025
847e0af
fix error with items that are already large images
BryonLewis Nov 18, 2025
4bd803d
fix loading OSM issues with referencing external URLs
BryonLewis Nov 20, 2025
12262ce
add notification so that reloading prompt occurs after conversion
BryonLewis Nov 20, 2025
e9d359e
more precise exception logic for large image conversion
BryonLewis Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions server/dive_tasks/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ def convert_images(self: Task, folderId, user_id: str, user_login: str):
command = ["ffmpeg", "-i", str(item_path), str(new_item_path)]
utils.stream_subprocess(self, context, manager, {'args': command})
gc.uploadFileToFolder(folderId, new_item_path)
gc.delete(f"item/{item['_id']}")
gc.delete(f"item/{str(item['_id'])}")

gc.addMetadataToFolder(
str(folderId),
Expand Down Expand Up @@ -677,7 +677,12 @@ def convert_large_images(self: Task, folderId, user_id: str, user_login: str):
]
for item in items_to_convert:
# Assumes 1 file per item
gc.post(f'item/{item["_id"]}/tiles')
try:
gc.get(f'item/{str(item["_id"])}/tiles')
manager.write(f'Skipping {item["name"]}, already a large image\n')
continue
except Exception:
Comment thread
naglepuff marked this conversation as resolved.
Outdated
gc.post(f'item/{str(item["_id"])}/tiles')
gc.addMetadataToFolder(
str(folderId),
{"type": constants.LargeImageType}, # mark the parent folder as able to annotate.
Expand Down
Loading