fix: correct CI pre-commit invocation and coverage upload path#15
Open
mattdawkins wants to merge 1 commit intoKitware:mainfrom
Open
fix: correct CI pre-commit invocation and coverage upload path#15mattdawkins wants to merge 1 commit intoKitware:mainfrom
mattdawkins wants to merge 1 commit intoKitware:mainfrom
Conversation
Two fixes in the testing workflow: 1. Remove bare `pre-commit` call (no subcommand) which just prints help text and wastes CI time. Only `pre-commit run --all-files` is needed. 2. Fix Codecov upload path from `./coverage/coverage.xml` to `./coverage.xml`. pytest-cov with `--cov-report=xml` writes coverage.xml to the working directory by default, not a coverage/ subdirectory. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes in the testing workflow:
pre-commitcall (line 42) — Runningpre-commitwithout a subcommand just prints help text and exits 0. Onlypre-commit run --all-filesis needed../coverage/coverage.xmlto./coverage.xml.pytest-covwith--cov-report=xmlwrites to the working directory by default, not acoverage/subdirectory. Coverage was never actually being uploaded.Test plan
🤖 Generated with Claude Code