Update the twist codemod to use the new position tools - #9331
Merged
Conversation
Replaces manual extraction and error handling of the twistCenter argument with a call to extractKclArgument for improved readability and maintainability.
Replaces valueOrVariable with createPoint2dExpression when constructing the twistCenter argument in addExtrude. This ensures twistCenter is always represented as a 2D point expression, improving type safety and correctness.
Introduces a new test case to verify that the addExtrude function correctly handles extrude calls with all twist-related parameters (twistAngle, twistAngleStep, twistCenter). Ensures the generated code includes these parameters as expected.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
12 tasks
max-mrgrsk
changed the title
max-mrgrsk
marked this pull request as ready for review
December 12, 2025 15:17
pierremtb
reviewed
Dec 12, 2025
pierremtb
left a comment
pierremtb
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thank you for making the changes. Will test on Vercel and approve
Contributor
|
Nice, working well here! |
pierremtb
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish along: ZDS support for Extrude Surface
Follow up of #9301
operations.tsto use theextractKclArgument()helpersweeps.tsto usecreatePoint2dExpression()for robust Point2D handling, matching the pattern used by other vector2d parameters likegdt framePosition.twistfunctionality