Conversation
|
Need to add a few tests will mark it as ready once that's done |
src/lang/modifyAst/sweeps.ts
Outdated
| wasmInstance, | ||
| mNodeToEdit | ||
| let vars: | ||
| | undefined |
There was a problem hiding this comment.
It looks like vars can never be undefined so this could be a const instead:
const vars: {
exprs: Expr[];
pathIfPipe?: PathToNode
} = {
exprs: []
}
There was a problem hiding this comment.
Good catch, thank you! I made the change to assignments at 305c1bc and didn't change it!
There was a problem hiding this comment.
I tried it out, works well!
One thing I noticed is that while extruding cap is stable, I'm having a difficult time reconnecting to the engine when extruding a wall - either from the vercel preview link or running ZDS locally with your branch.
The render appears but then it goes away and can't reconnect. Is this supposed to work?
sketch001 = startSketchOn(XZ)
profile001 = startProfile(sketch001, at = [-2.23, 3.89])
|> yLine(length = -7.78)
|> xLine(length = 5.58)
|> yLine(length = 7, tag = $seg01)
|> line(endAbsolute = [profileStartX(%), profileStartY(%)])
|> close()
extrude001 = extrude(profile001, length = 5)
extrude002 = extrude(seg01, length = 3)
|
@andrewvarga Thanks! Yes I believe it's engine bug, let me move the conversation to the Slack thread and we should report this together https://kittycadworkspace.slack.com/archives/C04KFV6NKL0/p1770128241914559?thread_ts=1769709536.629029&cid=C04KFV6NKL0 |
Closes #9392
Supports walls and caps. edgeCuts aren't supported by engine yet.
Clipboard-20260129-215402-819.mp4