Skip to content

P&C Integration of Extrude Face#8748

Merged
pierremtb merged 184 commits intomainfrom
pierremtb/extrude-face
Feb 3, 2026
Merged

P&C Integration of Extrude Face#8748
pierremtb merged 184 commits intomainfrom
pierremtb/extrude-face

Conversation

@pierremtb
Copy link
Copy Markdown
Contributor

@pierremtb pierremtb commented Oct 30, 2025

Closes #9392

Supports walls and caps. edgeCuts aren't supported by engine yet.

Clipboard-20260129-215402-819.mp4

@pierremtb pierremtb marked this pull request as ready for review January 29, 2026 20:47
@pierremtb pierremtb requested a review from a team as a code owner January 29, 2026 20:47
@pierremtb
Copy link
Copy Markdown
Contributor Author

Need to add a few tests will mark it as ready once that's done

@pierremtb pierremtb marked this pull request as draft January 29, 2026 21:07
@pierremtb pierremtb marked this pull request as ready for review January 29, 2026 21:55
@pierremtb pierremtb requested a review from max-mrgrsk January 29, 2026 21:55
wasmInstance,
mNodeToEdit
let vars:
| undefined
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like vars can never be undefined so this could be a const instead:

const vars: { 
exprs: Expr[];
pathIfPipe?: PathToNode
} = {
  exprs: []
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! I made the change to assignments at 305c1bc and didn't change it!

Copy link
Copy Markdown
Contributor

@andrewvarga andrewvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out, works well!

One thing I noticed is that while extruding cap is stable, I'm having a difficult time reconnecting to the engine when extruding a wall - either from the vercel preview link or running ZDS locally with your branch.

The render appears but then it goes away and can't reconnect. Is this supposed to work?

sketch001 = startSketchOn(XZ)
profile001 = startProfile(sketch001, at = [-2.23, 3.89])
  |> yLine(length = -7.78)
  |> xLine(length = 5.58)
  |> yLine(length = 7, tag = $seg01)
  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
  |> close()
extrude001 = extrude(profile001, length = 5)
extrude002 = extrude(seg01, length = 3)

@pierremtb pierremtb merged commit 9d3531d into main Feb 3, 2026
58 checks passed
@pierremtb pierremtb deleted the pierremtb/extrude-face branch February 3, 2026 14:14
@pierremtb
Copy link
Copy Markdown
Contributor Author

@andrewvarga Thanks! Yes I believe it's engine bug, let me move the conversation to the Slack thread and we should report this together https://kittycadworkspace.slack.com/archives/C04KFV6NKL0/p1770128241914559?thread_ts=1769709536.629029&cid=C04KFV6NKL0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extrude from faces

5 participants