Skip to content

Guidance for PR descriptions - #13557

Merged
pierremtb merged 2 commits into
mainfrom
pierremtb/adhoc/agents-pr-desc
Sep 1, 2026
Merged

Guidance for PR descriptions#13557
pierremtb merged 2 commits into
mainfrom
pierremtb/adhoc/agents-pr-desc

Conversation

@pierremtb

Copy link
Copy Markdown
Contributor

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modeling-app Ready Ready Preview Sep 1, 2026 5:39pm UTC

Request Review

@jacebrowning

jacebrowning commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

I think we should request that PRs are opened as drafts as well, minimally until CI is passing. It's hard to codify, but I think we want a policy that says the human that interacted with the agent brings it out of draft after a self-review.

I'd hope it doesn't need to be explicit, but it should also be understood that rewriting CI configuration in order to get a green status is basically never acceptable. Instead, separate issue and separate PR.

@pierremtb
pierremtb marked this pull request as ready for review September 1, 2026 17:31
@pierremtb
pierremtb requested review from a team as code owners September 1, 2026 17:31
@pierremtb

Copy link
Copy Markdown
Contributor Author

I think we should request that PRs are opened as drafts as well, minimally until CI is passing. It's hard to codify, but I think we want a policy that says the human that interacted with the agent brings it out of draft after a self-review.

I'd hope it doesn't need to be explicit, but it should also be understood that rewriting CI configuration in order to get a green status is basically never acceptable. Instead, separate issue and separate PR.

Right on, added in 9b4e7e7

@pierremtb
pierremtb enabled auto-merge (squash) September 1, 2026 17:31
@pierremtb
pierremtb merged commit 7979bd0 into main Sep 1, 2026
56 checks passed
@pierremtb
pierremtb deleted the pierremtb/adhoc/agents-pr-desc branch September 1, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants