Fix Hide/Delete on variable-less source pipes - #13408
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Plain-English validation intent: This check is meant to prove that Hide and Delete commands still work when the selected solid came from unassigned pipe-style KCL. The user-facing behavior being protected is: selecting a visible body and choosing Hide/Delete should attach the new operation to that exact selected source, even if the original modeling pipeline did not have a variable name. Latest local verification on PR head c48d9d2:
I am treating recovered broad CI/app-startup flakes from earlier runs as non-codemod noise because the focused codemod regression passes and the current check set is clean. |
|
Manual GUI-fuzz PR-preview validation update. Plain-English validation intent: Preview under test: Scenario exercised:
Validation evidence:
Runtime notes: Local artifact directory: |
Fixes #13407.
Fixes #13418.
Summary
Plain-English test intent
These tests model the user flow where one or more bodies exist only as bare KCL pipelines, the user selects those bodies, and then runs Hide or Delete from the modeling UI. The behavior under test is not the geometry operation itself; it is whether the point-and-click codemod keeps the selected body or bodies as the input. Passing means the command is attached to, or references, the objects the user actually selected instead of being emitted as a detached
hide()/delete()call or silently dropping one selected body.Validation
npm run test:integration -- src/lang/modifyAst/transformsVariablelessPipe.spec.tsnpm run test:integration -- src/lang/modifyAst/transformsVariablelessPipe.spec.ts src/lang/modifyAst/objectTransformMultiVariableless.audit.spec.tsnpx biome check src/lang/modifyAst/transforms.ts src/lang/modifyAst/transformsVariablelessPipe.spec.tsgit diff --checkThe committed integration test covers both
hideanddelete, asserts the single-selection operation is appended to the source pipe, asserts multi-selection materializes both source pipes assolid001/solid002, and confirms engineless execution reports no issues.The uncommitted audit repro for #13418 failed 2/2 before the latest fix and passes 2/2 after it.