Change the attachment request to pass a file handle rather than reading in the bytes#383
Merged
leplatrem merged 2 commits intoKinto:mainfrom Dec 11, 2024
Merged
Conversation
leplatrem
approved these changes
Dec 11, 2024
Contributor
leplatrem
left a comment
leplatrem
left a comment
There was a problem hiding this comment.
Thank you for taking the time to contribute the fix 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having some attachments get truncated when using this API, and tracked it down to the line where the file is being read into bytes. I'm not sure why this is truncating the file, but the fix is to pass in a file handle instead to requests.