Draft
Conversation
changes in animation panel
# Conflicts: # glTF-Sample-Renderer
Changes manually copied and adjusted from the gltfx branch
# Conflicts: # src/logic/uimodel.js # src/main.js # src/ui/ui.js
# Conflicts: # glTF-Sample-Renderer
|
|
Contributor
UX3D-hohenester
left a comment
UX3D-hohenester
left a comment
There was a problem hiding this comment.
the css classes need review. they seem redundant
| margin-top: 2.5em !important; | ||
| } | ||
|
|
||
| .round-green-btn { |
Contributor
There was a problem hiding this comment.
this class seems redundant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds:
KHR_interactivity
KHR_node_visibility
KHR_node_hoverability
KHR_node_selectability
KHR_accessor_float64
UI Changes:
Animation tab is replaced with Interactivity tab if KHR_interactivity is present and enabled.
Disable switches for KHR_interactivity, KHR_node_visibility, KHR_node_hoverability, KHR_node_selectability
Possibility to send custom events to interactivity engine.
Play, pause, reset, graph selection for interactivity.
Can be merged once the PR in glTF-Sample-Renderer is merged.