gpuav: Select pipeline to instrument post creation#12291
Open
arno-lunarg wants to merge 1 commit into
Open
Conversation
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 744964. |
Collaborator
|
CI Vulkan-ValidationLayers build # 23400 running. |
| return; | ||
| } | ||
|
|
||
| if (disabled[handle_wrapping]) { |
Contributor
There was a problem hiding this comment.
do this after MatchesAnyShaderSelectionRegex with a InternalError to let the user know they must have handle wrapping turned on
|
|
||
| VkPipeline instrumed_pipeline = VK_NULL_HANDLE; | ||
| if (pipeline_state->linking_shaders == 0 && | ||
| IsValueIn(pipeline_state->pipeline_type, {VK_PIPELINE_BIND_POINT_GRAPHICS, VK_PIPELINE_BIND_POINT_COMPUTE})) { |
Contributor
There was a problem hiding this comment.
leave comment why we are not able to do in ray tracing at the moment
| } | ||
|
|
||
| VkPipeline instrumed_pipeline = VK_NULL_HANDLE; | ||
| if (pipeline_state->linking_shaders == 0 && |
Contributor
There was a problem hiding this comment.
why not go
if (pipeline_state->pipeline_type == VK_PIPELINE_BIND_POINT_GRAPHICS) {
if (pipeline_state->linking_shaders == 0) {
} else {
}
} else if (pipeline_state->pipeline_type == VK_PIPELINE_BIND_POINT_COMPUTE) {
} else {
// comment about RTX
return;
}as I think that would be cleaner to follow when we add RTX in the future
|
|
||
| const VkResult result = | ||
| DispatchCreateGraphicsPipelines(device, VK_NULL_HANDLE, 1, new_pipeline_ci.ptr(), nullptr, &instrumed_pipeline); | ||
| if (result != VK_SUCCESS || instrumed_pipeline == VK_NULL_HANDLE) { |
Collaborator
|
CI Vulkan-ValidationLayers build # 23400 failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.