layers: Revert old swapchain fix#11993
Merged
artem-lunarg merged 1 commit intoKhronosGroup:mainfrom Mar 27, 2026
Merged
Conversation
Original PR: KhronosGroup#10506 I think that PR was wrong (general rule you can't delete in-use resources). Will redo if I'm wrong. Currently this blocks another fix. Clarification question: https://gitlab.khronos.org/vulkan/vulkan/-/issues/4761
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 692136. |
Collaborator
|
CI Vulkan-ValidationLayers build # 22971 running. |
| m_default_queue->Wait(); | ||
| } | ||
|
|
||
| TEST_F(PositiveWsi, DestroySwapchainBeforeLayoutValidation) { |
Contributor
There was a problem hiding this comment.
would this be a negative test now?
Contributor
Author
There was a problem hiding this comment.
i think so, will add in the next PR
spencer-lunarg
approved these changes
Mar 27, 2026
Collaborator
|
CI Vulkan-ValidationLayers build # 22971 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR:
#10506
I think that PR was wrong (general rule you can't delete in-use resources). Will redo if I'm wrong. Currently this blocks another fix.
Clarification question:
https://gitlab.khronos.org/vulkan/vulkan/-/issues/4761
UPDATE: got confirmation