Skip to content

RFC: Initial headers from Vulkan usability improvements #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pdaniell-nv wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

RFC: Initial headers from Vulkan usability improvements #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c180c3b
Initial headers from Vulkan usability improvements
pdaniell-nv Feb 3, 2026
715c308
const-ref inline function experiments
pdaniell-nv Feb 4, 2026
250fccc
Tweak to allow passing in temporary arrays as spans
pdaniell-nv Feb 5, 2026
80e253c
Remove unnecessary profile changes
pdaniell-nv Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 36 additions & 22 deletions include/vulkan/vulkan_android.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ struct ANativeWindow;
#define VK_KHR_ANDROID_SURFACE_EXTENSION_NAME "VK_KHR_android_surface"
typedef VkFlags VkAndroidSurfaceCreateFlagsKHR;
typedef struct VkAndroidSurfaceCreateInfoKHR {
VkStructureType sType;
const void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_ANDROID_SURFACE_CREATE_INFO_KHR);
const void* pNext VK_CPP11_DEFAULT(nullptr);
VkAndroidSurfaceCreateFlagsKHR flags;
struct ANativeWindow* window;
} VkAndroidSurfaceCreateInfoKHR;
Expand All @@ -41,6 +41,13 @@ VKAPI_ATTR VkResult VKAPI_CALL vkCreateAndroidSurfaceKHR(
const VkAndroidSurfaceCreateInfoKHR* pCreateInfo,
const VkAllocationCallbacks* pAllocator,
VkSurfaceKHR* pSurface);

#if VK_CPP20_FEATURES
extern "C++" inline VkResult vkCreateAndroidSurfaceKHR(VkInstance instance, const VkAndroidSurfaceCreateInfoKHR& pCreateInfo, VkSurfaceKHR* pSurface)
{
return vkCreateAndroidSurfaceKHR(instance, &pCreateInfo, nullptr, pSurface);
}
#endif
#endif
#endif

Expand All @@ -51,21 +58,21 @@ struct AHardwareBuffer;
#define VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_SPEC_VERSION 5
#define VK_ANDROID_EXTERNAL_MEMORY_ANDROID_HARDWARE_BUFFER_EXTENSION_NAME "VK_ANDROID_external_memory_android_hardware_buffer"
typedef struct VkAndroidHardwareBufferUsageANDROID {
VkStructureType sType;
void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_ANDROID_HARDWARE_BUFFER_USAGE_ANDROID);
void* pNext VK_CPP11_DEFAULT(nullptr);
uint64_t androidHardwareBufferUsage;
} VkAndroidHardwareBufferUsageANDROID;

typedef struct VkAndroidHardwareBufferPropertiesANDROID {
VkStructureType sType;
void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_ANDROID_HARDWARE_BUFFER_PROPERTIES_ANDROID);
void* pNext VK_CPP11_DEFAULT(nullptr);
VkDeviceSize allocationSize;
uint32_t memoryTypeBits;
} VkAndroidHardwareBufferPropertiesANDROID;

typedef struct VkAndroidHardwareBufferFormatPropertiesANDROID {
VkStructureType sType;
void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_ANDROID_HARDWARE_BUFFER_FORMAT_PROPERTIES_ANDROID);
void* pNext VK_CPP11_DEFAULT(nullptr);
VkFormat format;
uint64_t externalFormat;
VkFormatFeatureFlags formatFeatures;
Expand All @@ -77,26 +84,26 @@ typedef struct VkAndroidHardwareBufferFormatPropertiesANDROID {
} VkAndroidHardwareBufferFormatPropertiesANDROID;

typedef struct VkImportAndroidHardwareBufferInfoANDROID {
VkStructureType sType;
const void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_IMPORT_ANDROID_HARDWARE_BUFFER_INFO_ANDROID);
const void* pNext VK_CPP11_DEFAULT(nullptr);
struct AHardwareBuffer* buffer;
} VkImportAndroidHardwareBufferInfoANDROID;

typedef struct VkMemoryGetAndroidHardwareBufferInfoANDROID {
VkStructureType sType;
const void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_MEMORY_GET_ANDROID_HARDWARE_BUFFER_INFO_ANDROID);
const void* pNext VK_CPP11_DEFAULT(nullptr);
VkDeviceMemory memory;
} VkMemoryGetAndroidHardwareBufferInfoANDROID;

typedef struct VkExternalFormatANDROID {
VkStructureType sType;
void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_EXTERNAL_FORMAT_ANDROID);
void* pNext VK_CPP11_DEFAULT(nullptr);
uint64_t externalFormat;
} VkExternalFormatANDROID;

typedef struct VkAndroidHardwareBufferFormatProperties2ANDROID {
VkStructureType sType;
void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_ANDROID_HARDWARE_BUFFER_FORMAT_PROPERTIES_2_ANDROID);
void* pNext VK_CPP11_DEFAULT(nullptr);
VkFormat format;
uint64_t externalFormat;
VkFormatFeatureFlags2 formatFeatures;
Expand All @@ -123,6 +130,13 @@ VKAPI_ATTR VkResult VKAPI_CALL vkGetMemoryAndroidHardwareBufferANDROID(
VkDevice device,
const VkMemoryGetAndroidHardwareBufferInfoANDROID* pInfo,
struct AHardwareBuffer** pBuffer);

#if VK_CPP20_FEATURES
extern "C++" inline VkResult vkGetMemoryAndroidHardwareBufferANDROID(VkDevice device, const VkMemoryGetAndroidHardwareBufferInfoANDROID& pInfo, struct AHardwareBuffer** pBuffer)
{
return vkGetMemoryAndroidHardwareBufferANDROID(device, &pInfo, pBuffer);
}
#endif
#endif
#endif

Expand All @@ -132,22 +146,22 @@ VKAPI_ATTR VkResult VKAPI_CALL vkGetMemoryAndroidHardwareBufferANDROID(
#define VK_ANDROID_EXTERNAL_FORMAT_RESOLVE_SPEC_VERSION 1
#define VK_ANDROID_EXTERNAL_FORMAT_RESOLVE_EXTENSION_NAME "VK_ANDROID_external_format_resolve"
typedef struct VkPhysicalDeviceExternalFormatResolveFeaturesANDROID {
VkStructureType sType;
void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_EXTERNAL_FORMAT_RESOLVE_FEATURES_ANDROID);
void* pNext VK_CPP11_DEFAULT(nullptr);
VkBool32 externalFormatResolve;
} VkPhysicalDeviceExternalFormatResolveFeaturesANDROID;

typedef struct VkPhysicalDeviceExternalFormatResolvePropertiesANDROID {
VkStructureType sType;
void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_EXTERNAL_FORMAT_RESOLVE_PROPERTIES_ANDROID);
void* pNext VK_CPP11_DEFAULT(nullptr);
VkBool32 nullColorAttachmentWithExternalFormatResolve;
VkChromaLocation externalFormatResolveChromaOffsetX;
VkChromaLocation externalFormatResolveChromaOffsetY;
} VkPhysicalDeviceExternalFormatResolvePropertiesANDROID;

typedef struct VkAndroidHardwareBufferFormatResolvePropertiesANDROID {
VkStructureType sType;
void* pNext;
VkStructureType sType VK_CPP11_DEFAULT(VK_STRUCTURE_TYPE_ANDROID_HARDWARE_BUFFER_FORMAT_RESOLVE_PROPERTIES_ANDROID);
void* pNext VK_CPP11_DEFAULT(nullptr);
VkFormat colorAttachmentFormat;
} VkAndroidHardwareBufferFormatResolvePropertiesANDROID;

Expand Down
Loading