fix: metrics output to stderr if stdout is in use - #1240
Merged
MarkCallow merged 3 commits intoAug 8, 2026
Conversation
walcht
commented
Aug 6, 2026
walcht
commented
Contributor
- PSNR and SSIM metrics now ouput to stderr if stdout is in use. This is done to avoid polluting KTX file ouput to stdout which causes issues when, for instance, output gets piped to ktx extract tool.
- Fixes cli: compare-psnr doesn't work when writing ktx2 file to stdout #1233
* PSNR and SSIM metrics now ouput to stderr if stdout is in use. This is done to avoid polluting KTX file ouput to stdout which causes issues when, for instance, output gets piped to ktx extract tool. Signed-off-by: Walid Chtioui <walid.chtioui.main@gmail.com>
Collaborator
|
Windows, MingW and macOS all have test failures, the first two, many, the last, one. The other failures look like some GitHub runner issue. I have triggered rebuilds of those. Linux too, now that it has got past the runner issue, has many test failures. |
Signed-off-by: Walid Chtioui <walid.chtioui.main@gmail.com>
Contributor
Author
|
I forgot to move parent folders creation before creating the Anyway, it should be all good now. |
MarkCallow
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.