feat: capture mipmap generation options in writer metadata params - #1238
Open
walcht wants to merge 2 commits into
Open
feat: capture mipmap generation options in writer metadata params#1238walcht wants to merge 2 commits into
walcht wants to merge 2 commits into
Conversation
* This commit captures mipmap generation options in KTXWriterScParams metadata entry only if mipmap generation is enabled. This might help ktx2 file consumers to, for instance, regenerate the mipmaps using the same params. Signed-off-by: Walid Chtioui <walid.chtioui.main@gmail.com>
Contributor
Author
|
CTS PR: KhronosGroup/KTX-Software-CTS#82 The MingW CI is failing because I pushed CTS after pushing this PR; again, I keep forgetting to push CTS first ... |
MarkCallow
reviewed
Aug 6, 2026
Signed-off-by: Walid Chtioui <walid.chtioui.main@gmail.com>
Contributor
Author
Yes (to some degree). I enabled this for ASTC as well. For Basis Universal codecs it requires more work which is why I just ignored it.
Yes. This is just a heuristic for a rare use case that is advised against (unless input KTX2 file is not lossy compressed which is probably very rare). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Feature request: record mipmap generation options for ktx create/encode #1196
This commit captures mipmap generation options in KTXWriterScParams metadata entry only if mipmap generation is enabled. This might help ktx2 file consumers to, for instance, regenerate the mipmaps using the same params.