[Draft] BodyText linting part 2: no-invalid-bodytext-children#3015
Draft
marcysutton wants to merge 6 commits intomainfrom
Draft
[Draft] BodyText linting part 2: no-invalid-bodytext-children#3015marcysutton wants to merge 6 commits intomainfrom
marcysutton wants to merge 6 commits intomainfrom
Conversation
… for no-invalid-bodytext-parent to avoid nested paragraphs
…ext-children rule for flagging invalid children within the Bodytext component
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🦋 Changeset detectedLatest commit: 4199e63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Contributor
|
Size Change: +778 B (+0.63%) Total Size: 124 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (0fb92c6) and published all packages with changesets to npm. You can install the packages in ./dev/tools/deploy_wonder_blocks.js --tag="PR3015"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR3015 |
Contributor
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-jnevvyiccd.chromatic.com/ Chromatic results:
|
marcysutton
changed the title
marcysutton
force-pushed
the
WB-2247-bodytext-lint
branch
5 times, most recently
from
4bc6115 to
f554d3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This new lint rule will flag invalid children within BodyText:
viewChild— always warns whenViewis a direct child ofBodyText, regardless oftagpropdivChild— warns when<div>is a direct child andBodyTextrenders as<p>(notagortag="p")paragraphChild— warns when<p>or a default<BodyText>(renders as<p>) is a direct childblockChild— warns on other block-level HTML elements (section,ul,h1–h6, etc.) and WB heading components whenBodyTextrenders as<p>tooManyChildren— warns when direct JSX element children exceed a configurable threshold (default: 5)BodyTexthas an inline or block-container tag prop setIssue: WB-2248
Test plan: