[Image] | (CX) | Add a warning for large images#3505
Open
Conversation
If an image is too large, it can cause slowdowns in both the editor and for our learners. Add a warning here to let the content authors know if that's the case. Issue: https://khanacademy.atlassian.net/browse/LEMS-4050 Test plan: todo
github-actions
bot
added
the
schema-change
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
github-actions
bot
removed
the
schema-change
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
|
Size Change: +118 B (+0.02%) Total Size: 499 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (826070d) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3505If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3505If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3505 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
If an image is too large, it can cause slowdowns in both the editor and for our learners.
Add a warning here to let the content authors know if that's the case.
Issue: https://khanacademy.atlassian.net/browse/LEMS-4050
Test plan:
pnpm jest packages/perseus-editor/src/widgets/__tests__/image-editor.test.tsxStorybook
/?path=/story/editors-editorpage--with-all-flagshttps://cdn.kastatic.org/ka-perseus-images/01f44d5b73290da6bec97c75a5316fb05ab61f12.jpg)https://cdn.kastatic.org/ka-content-images/61831c1329dbc32036d7dd0d03e06e7e2c622718.jpg)