Remove unused default value for polygon points#3293
Open
benchristel wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
|
Size Change: -9 B (0%) Total Size: 485 kB
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (d1a49ed) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3293If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3293If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3293 |
catandthemachines
approved these changes
Mar 3, 2026
Member
catandthemachines
left a comment
catandthemachines
left a comment
There was a problem hiding this comment.
The code looks good, but I would like to request that when you roll this out to double check our error logs on the interactive graph for a day or two after. There were some weird edge case for polygons that could produce odd states that can break the polygon, and I can't remember if this was to prevent one. 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes a TODO comment.
coordscan't be null or undefined here.Issue: none
Test plan:
CI checks should pass.