Handle psutil dependency on emscripten#718
Open
ObservedObserver wants to merge 2 commits intomainfrom
Open
Conversation
Signed-off-by: Elwynn Chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_690a9d90947883228cb7cc50e0cd3722
Note
Make
psutiloptional on emscripten and harden nbconvert detection by safely reading the parent process cmdline.psutilwith fallback toNonewhen unavailable._get_parent_cmdline()with robust exception handling and use it incheck_convert()to detectjupyter-nbconvert.psutila conditional dependency (sys_platform != "emscripten") inpyproject.toml.Written by Cursor Bugbot for commit 5100dc4. Configure here.