You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that when you run the tests, they randomly fail, but typically not when I run them... weird.
I see you have some "suspects" for this behavior, like the max time or number of retries in some functions when you set wait parameter to True. Currently the max amount of time to wait is 1.375 seconds, which I fully agree it might not be enough fo CI tests, but I wonder the impact in "real-life" when raising that max value. The problem here is that the developers can not set that value according to their needs, so perhaps changing the wait parameter from bool to float, the developers can define the value which best fits their needs (thus, being 0 = no wait, any other value = max time in seconds to wait). The "new" problem with this solution is retro-compatibility...
Anyway, if you need help or just discuss some concepts, just let me know!
By the way, impressive work you've done so far... Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.