Skip to content

feat: Add solitaire game implementation#25

Open
Vertixx01 wants to merge 2 commits intoKaamkiya:mainfrom
Vertixx01:main
Open

feat: Add solitaire game implementation#25
Vertixx01 wants to merge 2 commits intoKaamkiya:mainfrom
Vertixx01:main

Conversation

@Vertixx01
Copy link

@Vertixx01 Vertixx01 commented Oct 1, 2025

Description

I made the solitaire game work and have it in a stable version that I tested — everything was working fine.

Motivation and Context

I just wanted to contribute to random open source projects for practice. This gave me a good chance to learn, practice, and get involved.

How has this been tested?

  • Tested manually by playing the game.
  • Confirmed everything works as expected.
  • Verified that it doesn’t affect other parts of the application.

Screenshots (if appropriate):

NVIDIA_Overlay_39i4AousQJ

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [✅] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • [✅] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Vertixx01 Vertixx01 changed the title feat: Add solitaire game implementation feat: Add solitaire game implementation and UI Improvement Oct 1, 2025
@Kaamkiya
Copy link
Owner

Kaamkiya commented Oct 1, 2025

Please don't rewrite the opening UI completely when implementing a new game.
I can't merge this if you keep that in your pull request.


image

The columns get misaligned when there is a card with more than two characters.

Once you fix these two things, we can talk about the rest of it. Thanks!

- Removed unnecessary spaces in variable declarations for consistency.
- Improved card string padding in the view function to ensure consistent width for display.
@Vertixx01 Vertixx01 changed the title feat: Add solitaire game implementation and UI Improvement feat: Add solitaire game implementation Oct 2, 2025
@Kaamkiya
Copy link
Owner

image

The columns get misaligned when there is a card with more than two characters.

@Vertixx01 do you mind fixing this?

@Kaamkiya Kaamkiya added the stale Hasn't been worked on; requested changes haven't been made. label Nov 26, 2025
@Kaamkiya
Copy link
Owner

Marked as stale due to inactivity. If you'd still like to work on it, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Hasn't been worked on; requested changes haven't been made.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants