Fix xi -> q mapping in testSample#2
Open
timofeymukha wants to merge 4 commits intoKTH-Nek5000:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the GLL sampling type for
testSampleis currently buggy. As I understand it, fortestSample, we are supposed to generate q, and then map it to xi. However, for the GLL case we end up doing both, starting with generating xi, mapping to q, and then mapping back. I think the first map from xi to q is incorrect.q_=xi_*(self.qBound[1]-self.qBound[0])+self.qBound[0]Assume
qBound = [0, 1], sincexi_is in [-1, 1] for GLL, it follows that the bounds forq_will bexi_*(1 - 0) + 0 = xi_, which is clearly wrong.To fix this, I just copied the mapping code from the
xi2q_mapfunction intrainSample. I think this does the job!