Conversation
lievenhey
force-pushed
the
diff-view
branch
2 times, most recently
from
ed32d25 to
786e577
Compare
Contributor
Author
|
|
Contributor
Author
|
The description of the table is not correct and the data might be a bit crappy |
Collaborator
is this still open or did you fix it now? |
milianw
requested changes
Oct 27, 2021
| @@ -0,0 +1,22 @@ | |||
| void action1() | |||
lievenhey
force-pushed
the
diff-view
branch
4 times, most recently
from
23916f1 to
04a1546
Compare
Contributor
Author
|
I know I still need to update the test files, but the approach taken to create the diff view should be better now. |
lievenhey
force-pushed
the
diff-view
branch
3 times, most recently
from
8bc5486 to
4f7a309
Compare
Contributor
Author
|
I tried adding diffing to the perfparser, but I don't know if this is the right way. Please tell me if the current way is acceptable or if I should try another one. |
milianw
reviewed
Nov 15, 2021
milianw
requested changes
Nov 15, 2021
lievenhey
force-pushed
the
diff-view
branch
2 times, most recently
from
cd7a4fa to
3752c0a
Compare
Contributor
Author
|
Still not done, I just wanted to save my progess |
milianw
requested changes
Nov 24, 2021
milianw
requested changes
Dec 14, 2021
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
nearly done, this is looking really good now, great work and idea with just adding the diff as another cost - I really like that!
lievenhey
force-pushed
the
diff-view
branch
2 times, most recently
from
24193bc to
e385487
Compare
milianw
requested changes
Dec 15, 2021
lievenhey
force-pushed
the
diff-view
branch
3 times, most recently
from
3884c11 to
6833b8d
Compare
lievenhey
force-pushed
the
diff-view
branch
2 times, most recently
from
b38eb4e to
299ae5c
Compare
milianw
requested changes
Sep 30, 2022
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
can you please squash the patches and add test coverage as well as a meaningful commit message. I would expect a basic summary therein (remember, the What and Why is important):
- which part of the
perf difffeature set is supported? - what problem does the diffcostproxy solve?
- how does on use this new feature?
furthermore, please also add a quick way to diff files from the command line, something like
hotspot --diff perf.data.old perf.data
Contributor
|
Other than the missing tests the docs would need an update. |
lievenhey
force-pushed
the
diff-view
branch
6 times, most recently
from
7e57a77 to
8f94380
Compare
lievenhey
force-pushed
the
diff-view
branch
3 times, most recently
from
f73e0ef to
ce85f08
Compare
lievenhey
force-pushed
the
diff-view
branch
4 times, most recently
from
50599ac to
c0c01a5
Compare
Contributor
|
Can you please update the docs (README and possibly a screenshot), too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.