fix: fixed a bug that arguments are wrongly sorted by name#64
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the version from v2.0.0-beta.2 to v2.0.0 (stable release) and includes several code quality improvements.
- Version bump from beta to stable release across all configuration files and schemas
- Removal of argument sorting logic in code generators
- Import statement organization to follow Go conventions
- Minor code cleanup (blank line removal, Dockerfile improvements)
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| v2/schema/cyamli-cli.schema.yaml | Updated schema $id URL to reference v2.0.0 |
| v2/schema/cyamli-cli.schema.json | Updated schema $id URL in JSON format |
| v2/schema/cli_schema.go | Reorganized imports and removed blank line |
| v2/generate/typescript/data.go | Removed argument sorting logic |
| v2/generate/python3/data.go | Removed argument sorting logic |
| v2/generate/php/data.go | Removed argument sorting logic |
| v2/generate/kotlin/data.go | Removed argument sorting logic |
| v2/generate/golang/data.go | Removed argument sorting logic |
| v2/generate/dart3/data.go | Removed argument sorting logic |
| v2/generate/csharp/data.go | Removed argument sorting logic |
| v2/generate/cpp/data.go | Reorganized imports and removed argument sorting logic |
| v2/cmd/cyamli/cli.gen.go | Updated GetVersion() return value |
| v2/cmd/cyamli/cli.cyamli.yaml | Updated version field |
| test/dart3/Dockerfile | Added workspace setup and copy commands |
| docs/cyamli-docs.text | Updated version in documentation |
| docs/cyamli-docs.md | Updated version in documentation header |
| docs/cyamli-docs.html | Updated version in title and heading |
| docs/cyamli-cli.schema.yaml | Updated schema $id URL |
| docs/cyamli-cli.schema.json | Updated schema $id URL in JSON format |
Comments suppressed due to low confidence (1)
test/dart3/Dockerfile:3
- The WORKDIR directive is duplicated on lines 3 and 8. The first instance on line 3 already sets the working directory, making the second instance on line 8 redundant. Remove line 8 to avoid confusion.
WORKDIR /workspace
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project from version
v2.0.0-beta.2to the stable releasev2.0.0and includes several related changes to documentation, schema files, code generation, and Docker configuration. The changes ensure consistency across all files and remove unnecessary code in argument sorting.Version update and documentation:
v2.0.0-beta.2tov2.0.0in documentation files (docs/cyamli-docs.md,docs/cyamli-docs.text,docs/cyamli-docs.html,v2/cmd/cyamli/cli.cyamli.yaml,v2/cmd/cyamli/cli.gen.go) and schema files (docs/cyamli-cli.schema.yaml,docs/cyamli-cli.schema.json). [1] [2] [3] [4] [5] [6] [7]Code generation and data handling:
Removed wrong sorting of command arguments in code generators for all supported languages (
cpp,csharp,dart3,golang,kotlin,php,python3,typescript). This fixes the data construction process and ensures argument order is preserved as defined in the schema. [1] [2] [3] [4] [5] [6] [7] [8]Minor import reordering in
v2/generate/cpp/data.goandv2/schema/cli_schema.gofor code style consistency. [1] [2]Docker and build configuration:
/workspaceand copy the project files before running dependency installation, improving build reliability.Other minor changes:
validatemethod inv2/schema/cli_schema.gofor code cleanliness.