feat: automatically use EnvHttpProxyAgent for HTTP-proxy support#52
Open
mgraf158 wants to merge 1 commit into
Open
feat: automatically use EnvHttpProxyAgent for HTTP-proxy support#52mgraf158 wants to merge 1 commit into
mgraf158 wants to merge 1 commit into
Conversation
This patch makes pino-loki automatically detect proxy settings from the environment (HTTP_PROXY / HTTPS_PROXY / NO_PROXY) using undici's EnvHttpProxyAgent. This ensures that logs are correctly sent in corporate network environments without requiring manual dispatcher injection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes
pino-lokiautomatically detect proxy settings from the environment variables (HTTP_PROXY/HTTPS_PROXY/NO_PROXY) usingundici'sEnvHttpProxyAgent. This ensures that logs are correctly sent in corporate network environments without requiring manual dispatcher injection.Background:
Before this patch, there was no way to pass a proxy/agent to
pino‑loki’s HTTP implementation.Node’s native
fetch()does not currently pick upundici.setGlobalDispatcher()when fetch is invoked — especially in Node 20/22 wherefetchis backed by the built‑inundici.This patch closes that gap and makes
pino‑lokiusable in proxied environments without workarounds.