Reduce init args and refactor calculate_biological_precision#183
Merged
Reduce init args and refactor calculate_biological_precision#183
Conversation
…on. Make _get_marker_comparison static
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the acquisition dependent arguments to init to kwargs.
The corresponding attributes are no longer used internally.
Init, and reading related funcitons are now documented and have type hints.
New private static method _calculate_biological_precision -> to make it testable
Two private functions were made static and are implicitly tested by the new tests.
Two new tests for calculate_biological_precision - one to test attribute handling by the public method and a test for the numerical results of the private method.