Aqua+explicitimports

[j-fu]

Add Aqua, ExplicitImports and UndocumentedNames tests.

[Pangoraw]

tests are failing with:

  Expression: ExplicitImports.check_all_qualified_accesses_are_public(ThisPackage) === nothing
  NonPublicQualifiedAccessException
  Module `ExpressionExplorer` has explicit imports of names from modules in which they are not public (i.e. exported or declared public in Julia 1.11+):
  - `reverse` is not public in `Base.Iterators` but it was imported from `Base.Iterators` at `/home/runner/work/ExpressionExplorer.jl/ExpressionExplorer.jl/src/./explore.jl:450:42`

[fonsp]

Weird, that function is public: https://docs.julialang.org/en/v1/base/iterators/#Base.Iterators.reverse

[Pangoraw]

Probably only from 1.12 onwards:

julia> versioninfo()
Julia Version 1.11.9
Commit 53a02c0720c (2026-02-06 00:27 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: macOS (arm64-apple-darwin24.0.0)
  CPU: 10 × Apple M4
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, apple-m1)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

julia> Base.ispublic(Base.Iterators, :reverse)
false

[fonsp]

I guess that it's one of those functions that was public but they forgot to mark it

[Pangoraw]

yes, let's disable for the LTS?

[Pangoraw]

thanks

[Pangoraw]

it seems Aqua.test_all already does this?

Can you confirm

https://juliatesting.github.io/Aqua.jl/stable/test_all/#Aqua.test_all