Adding Functionality for Linearized Optimal Transport Computations#187
Open
dcgentile wants to merge 7 commits intoJuliaOptimalTransport:masterfrom
Open
Adding Functionality for Linearized Optimal Transport Computations#187dcgentile wants to merge 7 commits intoJuliaOptimalTransport:masterfrom
dcgentile wants to merge 7 commits intoJuliaOptimalTransport:masterfrom
Conversation
matbesancon
reviewed
Aug 6, 2025
|
|
||
| See also: [`sinkhorn2`](@ref) | ||
| """ | ||
|
|
Contributor
There was a problem hiding this comment.
you should not leave a space between the docstring and the function itself, otherwise it will be detached
matbesancon
reviewed
Aug 6, 2025
| we have O(n^2) distances to compute | ||
|
|
||
| Note that the choice of reference measure can significantly affect the quality of the approximation, and as of writing there is | ||
| no non-heauristic method for choosing a "good" reference. |
Contributor
There was a problem hiding this comment.
Suggested change
| no non-heauristic method for choosing a "good" reference. | |
| no provable method for choosing a "good" reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for writing a great package. I'm currently utilizing it for a research project where I need to compute O(n^2) transport costs, and to alleviate some of the computational cost, I am approximating the distance via a statistical estimator for the linearization of the Wasserstein distance. To get that estimator, one only needs access to the Sinkhorn potentials, but as far as I could tell, there wasn't an straightforward way to access those as the package currently exists. Therefore, I added one function that returns the Sinkhorn potentials, rather than the plan or the cost, and another function which returns a function that evaluates the estimator of transport map.