Make Aqua ignore FiniteDifferences#525
Conversation
|
IMO that's an issue of how FiniteDifferences runs tests but not a SpecialFunctions issue, hence it should be fixed in FiniteDifferences but not in SpecialFunctions. |
|
I'm not sure how it could be fixed in FiniteDifferences without something like modifying |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #525 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 14 14
Lines 3026 3026
=======================================
Hits 2853 2853
Misses 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I removed the JET compat bound in f7eb8a7. I think it'll be less work to keep up with any API changes than ensure that we have compat for the latest Julia version. |
|
Well, that broke the tests again. And I agree with @devmotion this sounds like a problem in FiniteDifferences |
|
Blegh, reverted. How would you fix it in FiniteDifferences? |
|
I don't know, I haven't looked at what they're doing 🙂 |
|
Hmm could probably make it work with a new environment that dev's both FiniteDifferences and SpecialFunctions. |
|
Yes, that's what should be done. You have to create a separate (temporary?) environment with both packages and then call Pkg.test with the desired package. |
|
Closing in favour of the fix in JuliaDiff/FiniteDifferences.jl#248. |
Should fix these failures: https://github.com/JuliaDiff/FiniteDifferences.jl/actions/runs/23706686900/job/69059656795?pr=248