method to lift checkbounds ambiguity#615
Merged
mkitti merged 1 commit intoJuliaMath:masterfrom Apr 21, 2025
Merged
Conversation
Collaborator
|
Looks promising. Thank you. I will check in later today. Please ping me later if I do not take action here. |
Collaborator
|
Would tests pass on Julia 1.10 LTS? |
Contributor
Author
|
Confirmed that this fixes the method ambiguity on 1.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the test failure due to ambiguous
checkboundsmethods. After merging this and #614, all tests should pass on master with julia 1.11.