Skip to content

Replace LScene by Axis3 (attempt 2)#1357

Open
juliohm wants to merge 3 commits intomasterfrom
makie-axis3
Open

Replace LScene by Axis3 (attempt 2)#1357
juliohm wants to merge 3 commits intomasterfrom
makie-axis3

Conversation

@juliohm
Copy link
Copy Markdown
Member

@juliohm juliohm commented Apr 11, 2026

Based on MakieOrg/Makie.jl#5375

Works as expected, but it would be nice if we could define the preferred_axis_attributes for the object being plotted like we already do with args_preferred_axis. If we can specialize the method for the object, we can extract additional information like the units along each axis to place in the labels.

This was referenced Apr 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2026

Benchmark Results (Julia v1)

Time benchmarks
master 4389863... master / 4389863...
clipping/SutherlandHodgman 2.62 ± 0.24 μs 2.6 ± 0.24 μs 1.01 ± 0.13
discretization/simplexify 0.425 ± 0.058 ms 0.426 ± 0.058 ms 0.996 ± 0.19
intersection/ray-triangle 0.05 ± 0.01 μs 0.05 ± 0.01 μs 1 ± 0.28
intersects/triangle-tetrahedron 0.391 ± 0.001 μs 0.391 ± 0.01 μs 1 ± 0.026
sideof/ring/large 6.79 ± 0.12 μs 6.78 ± 0.011 μs 1 ± 0.018
sideof/ring/small 0.06 ± 0 μs 0.06 ± 0 μs 1 ± 0
topology/half-edge 2.72 ± 0.19 ms 2.76 ± 0.22 ms 0.985 ± 0.11
winding/mesh 15.4 ± 0.3 ms 15.4 ± 0.23 ms 1 ± 0.025
time_to_load 1.01 ± 0.0041 s 1.02 ± 0.0055 s 0.991 ± 0.0067
Memory benchmarks
master 4389863... master / 4389863...
clipping/SutherlandHodgman 0.064 k allocs: 5.55 kB 0.064 k allocs: 5.55 kB 1
discretization/simplexify 0.0362 M allocs: 1.93 MB 0.0362 M allocs: 1.93 MB 1
intersection/ray-triangle 0 allocs: 0 B 0 allocs: 0 B
intersects/triangle-tetrahedron 4 allocs: 0.266 kB 4 allocs: 0.266 kB 1
sideof/ring/large 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/small 0 allocs: 0 B 0 allocs: 0 B
topology/half-edge 25.9 k allocs: 3.17 MB 25.9 k allocs: 3.17 MB 1
winding/mesh 0.0413 M allocs: 3.08 MB 0.0413 M allocs: 3.08 MB 1
time_to_load 0.149 k allocs: 11.1 kB 0.149 k allocs: 11.1 kB 1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2026

Benchmark Results (Julia vlts)

Time benchmarks
master 4389863... master / 4389863...
clipping/SutherlandHodgman 3.75 ± 0.26 μs 3.8 ± 0.24 μs 0.987 ± 0.093
discretization/simplexify 0.677 ± 0.028 ms 0.677 ± 0.12 ms 1 ± 0.18
intersection/ray-triangle 0.05 ± 0 μs 0.05 ± 0 μs 1 ± 0
intersects/triangle-tetrahedron 0.411 ± 0.001 μs 0.411 ± 0.02 μs 1 ± 0.049
sideof/ring/large 7.38 ± 0.01 μs 7.38 ± 0.01 μs 1 ± 0.0019
sideof/ring/small 0.06 ± 0.01 μs 0.051 ± 0.01 μs 1.18 ± 0.3
topology/half-edge 2.95 ± 0.049 ms 2.92 ± 0.04 ms 1.01 ± 0.022
winding/mesh 14.2 ± 0.17 ms 14.2 ± 0.12 ms 1 ± 0.014
time_to_load 1.2 ± 0.025 s 1.19 ± 0.024 s 1.01 ± 0.03
Memory benchmarks
master 4389863... master / 4389863...
clipping/SutherlandHodgman 0.053 k allocs: 4.97 kB 0.053 k allocs: 4.97 kB 1
discretization/simplexify 18.1 k allocs: 1.92 MB 18.1 k allocs: 1.92 MB 1
intersection/ray-triangle 0 allocs: 0 B 0 allocs: 0 B
intersects/triangle-tetrahedron 3 allocs: 0.344 kB 3 allocs: 0.344 kB 1
sideof/ring/large 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/small 0 allocs: 0 B 0 allocs: 0 B
topology/half-edge 18.1 k allocs: 2.92 MB 18.1 k allocs: 2.92 MB 1
winding/mesh 23.2 k allocs: 3.08 MB 23.2 k allocs: 3.08 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2026

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.57%. Comparing base (786abe4) to head (4389863).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
ext/MeshesMakieExt.jl 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
- Coverage   85.79%   85.57%   -0.23%     
==========================================
  Files         200      200              
  Lines        6436     6453      +17     
==========================================
  Hits         5522     5522              
- Misses        914      931      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant