update traefik to v2.x#396
Open
ycyin wants to merge 5 commits into
Open
Conversation
Joxit
reviewed
Sep 21, 2024
Owner
|
Hi, thank you for your contribution 😄 I posted one comment in your PR |
jnovack
reviewed
Mar 4, 2025
jnovack
reviewed
Mar 4, 2025
jnovack
reviewed
Mar 4, 2025
jnovack
reviewed
Mar 4, 2025
jnovack
reviewed
Mar 7, 2025
jnovack
left a comment
jnovack
left a comment
There was a problem hiding this comment.
I am not part of the team, just making suggestions.
| memory: 8g | ||
| reservations: | ||
| cpus: '1' | ||
| memory: 2g |
There was a problem hiding this comment.
SUGGESTION:
These limits and reservations are way to egregious for testing (even for some swarm productions)! I understand it's an example, but I feel we can be a little bit more responsible with examples.
Traefik v2 takes up ~40MB RAM idle, you don't need reserve 2G (it's not V3! HA!)
Suggested:
limits:
cpus: '2'
memory: 4g
reservations:
cpus: '0.1'
memory: 128MB
| - --entryPoints.web.forwardedHeaders.insecure | ||
| # - --entryPoints.websecure.address=:443 | ||
| environment: | ||
| - TZ=Asia/Shanghai |
There was a problem hiding this comment.
SUGGESTION:
Again, make it neutral to the most amount of people. TZ=UTC would be neutral.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated traefik example #380
This is the version I'm using on production