Simplify binding.gyp#149
Open
davedoesdev wants to merge 3 commits intoJoshKaufman:masterfrom
davedoesdev:master
Open
Simplify binding.gyp#149davedoesdev wants to merge 3 commits intoJoshKaufman:masterfrom davedoesdev:master
davedoesdev wants to merge 3 commits intoJoshKaufman:masterfrom
davedoesdev:master
Conversation
On Windows from Node 6.3.0 onwards the OpenSSL symbols are exported so we don't need to look for them. Further, OpenSSL 1.1.0 onwards has renamed the libraries so not relying on a given name means we don't have to detect which version is installed.
Collaborator
|
I'm looking for a new maintainer: https://github.com/quartzjer/ursa#maintainer-needed |
Contributor
Author
|
I guess the first question is what are the alternatives if ursa went away? |
This was referenced Sep 19, 2016
|
I have had no success install ursa on Node 6.10.0 or 7.6.0 on Windows 10. When you said 6.3.0 did you mean that version or earlier? |
Owner
|
@davedoesdev it's been awhile since you worked on this, how do you feel about it?
|
Contributor
Author
|
I've moved away from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, Node 6.3.0 exports the OpenSSL symbols which means we don't have to look for them. It also means we don't have hassle when OpenSSL change their library names as happened in 1.1.0.
Note if this change goes in then on Windows ursa would require Node 6.3.0 or above.
I'm not sure whether this would be an acceptable price to pay for more reliable Windows support going forward.