Reset scope when create new bouncer instance#650
Open
comhon-project wants to merge 1 commit intoJosephSilber:masterfrom
Open
Reset scope when create new bouncer instance#650comhon-project wants to merge 1 commit intoJosephSilber:masterfrom
comhon-project wants to merge 1 commit intoJosephSilber:masterfrom
Conversation
Author
|
@JosephSilber is this repository still maintained ? |
Author
|
up! |
Author
|
Anybody there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello team!
the Scope is persistent between several application initialization (typically during tests).
the scope is defined as a static value in Silber\Bouncer\Database\Models and is not reset when bouncer service is initialized.
Due to this, the scope is not reset between tests.
So the solution that I propose is to reset scope when create new bouncer instance
linked to issue 643