Skip to content

feat: add image stats to metadata - #525

Closed
nick-vincent wants to merge 1 commit into
JonasKruckenberg:mainfrom
nick-vincent:issue-377/stats-in-metadata
Closed

feat: add image stats to metadata#525
nick-vincent wants to merge 1 commit into
JonasKruckenberg:mainfrom
nick-vincent:issue-377/stats-in-metadata

Conversation

@nick-vincent

Copy link
Copy Markdown
Contributor

Meant to address #377


Quick Checklist

  • I have read the contributing guidelines
  • I have written new tests, as applicable (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • I have added a changeset, if applicable

@changeset-bot

changeset-bot Bot commented Apr 2, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 91da726

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Apr 17, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (bbfa8ca) to head (91da726).
Report is 238 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          33       33           
  Lines        1149     1151    +2     
  Branches      238      238           
=======================================
+ Hits         1114     1116    +2     
  Misses         35       35           
Flag Coverage Δ
imagetools-core 98.72% <100.00%> (+<0.01%) ⬆️
rollup-plugin-imagetools 99.25% <ø> (ø)
vite-imagetools 85.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manucorporat

Copy link
Copy Markdown

What would take to merge this?

@benmccann

Copy link
Copy Markdown
Collaborator

This feels a bit difficult to use from the user's side. I think something like #662 with an option to use the dominant color would probably be more user friendly

@nick-vincent nick-vincent closed this by deleting the head repository Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants